This repository was archived by the owner on Feb 15, 2026. It is now read-only.
Conversation
added 2 commits
December 19, 2025 14:24
…chemaExportService to use factory pattern, and enhance CLI with database type detection.
…tic and update CLI to use the new static method.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| services.AddSingleton<Func<DatabaseType, ISchemaExtractor>>(serviceProvider => | ||
| { | ||
| var factory = new SchemaExtractorFactory(); | ||
| return (databaseType) => SchemaExtractorFactory.CreateExtractor(databaseType); |
There was a problem hiding this comment.
Bug: Unused factory instance created but never referenced
The variable factory is instantiated with new SchemaExtractorFactory() on line 67 but is never used. The next line calls SchemaExtractorFactory.CreateExtractor(databaseType) as a static method, meaning the instance is completely unnecessary. This appears to be leftover code from when the method was possibly an instance method, and the instantiation was not removed when it was changed to static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
add PostgreSqlSchemaExtractor, update SchemaExportService to use factory pattern, and enhance CLI with database type detection.
Type of Change
Changes Made
Checklist
Note
Adds PostgreSQL schema extraction, refactors to an extractor factory, and updates the CLI to select or auto-detect database type.
PostgreSqlSchemaExtractorwith Npgsql; add Npgsql dependency.SchemaExtractorFactoryto instantiateISchemaExtractorperDatabaseType.DatabaseTypeenum (SqlServer,PostgreSql).SchemaExportServicerefactored to use factory (Func<DatabaseType, ISchemaExtractor>); improved logging includesDatabaseType.SchemaExportRequestupdated to includeDatabaseType.--database-type(-d) option; auto-detect database type from connection string; print detected type and app version.README.mdandCHANGELOG.mdfor PostgreSQL support, cross-database comparison, and new CLI options.Written by Cursor Bugbot for commit 11b43f2. This will update automatically on new commits. Configure here.